ci: update to not auto fix lint errors #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-jenn-or
approved these changes
Apr 8, 2022
| @@ -32,7 +32,8 @@ | |||
| "g:test:factory": "hygen test factory --name", | |||
| "g:test:request": "hygen test request --name", | |||
| "g:test:util": "hygen test util --name", | |||
| "lint": "yarn eslint . --ext .ts,.tsx --fix --ignore-pattern tmp", | |||
| "lint": "yarn eslint . --ext .ts,.tsx --ignore-pattern tmp", | |||
| "lint:fix": "yarn eslint . --ext .ts,.tsx --fix --ignore-pattern tmp", | |||
There was a problem hiding this comment.
I prefer this separation! Great add to not just pull out the ability to fix, but to create another distinct script.
There was a problem hiding this comment.
If you want to make sure both scripts do the same thing, except for fixing lint errors, you could do:
lint:fix": "yarn lint --fix"
There was a problem hiding this comment.
Thanks Cully. Made this chnage.
cullylarson
approved these changes
Apr 14, 2022
| @@ -32,7 +32,8 @@ | |||
| "g:test:factory": "hygen test factory --name", | |||
| "g:test:request": "hygen test request --name", | |||
| "g:test:util": "hygen test util --name", | |||
| "lint": "yarn eslint . --ext .ts,.tsx --fix --ignore-pattern tmp", | |||
| "lint": "yarn eslint . --ext .ts,.tsx --ignore-pattern tmp", | |||
| "lint:fix": "yarn eslint . --ext .ts,.tsx --fix --ignore-pattern tmp", | |||
There was a problem hiding this comment.
If you want to make sure both scripts do the same thing, except for fixing lint errors, you could do:
lint:fix": "yarn lint --fix"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
yarn lintto not auto fix lint errors. This was being run in the CI, so the lint step would pass even when lint errors exist.yarn lint:fixscript that can auto fix lint errorsChecklist